Se7en

~ Se7en

As an example (albeit a contrived one), here’s some ways to concatenate strings in C#:

Ex1.
string s1 = “One” + ” ” + “Two”;

Ex2.
string s3 = string.Format(”{0} {1}”, “One”, “Two”);

Ex3.
string s1 = “One”;
string s2 = “Two”;
string s3 = Concat(s1, s2);

public string Concat(string first, string second) {
int counter = 0;
string result = new string(first.Length + second.Length);
for (counter=0; i < first.Length; counter++) {
result[counter] = first[c];
}
for (counter = second.Length - 1; counter >= 0; counter–) {
result[counter] = second[c];
}
return result;
}

Ex2 is probably the best of the 3 but there is nothing stopping anyone from writing the terribly bad Ex3. And it will pass any unit tests you write for it.

We need to look to other devices to ensure we don’t write code like that. Performance testing or Memory allocation type tests may show some indicator that the code is cr4p. Code complexity might also be an indicator.

In the case above, a code review if probably the easiest way to identify problem areas like that, but then again if we’re all drinking the same kool-aid, maybe we wouldn’t notice.

Interesting point indeed, and probably worth more thought, thank you for bringing it up!

With BDD however, is there not the risk of bad coding becoming an issue? I’m not much of a coder; I code in PHPMySQL, websites basically, and the only game I had a hand in making worked, but the code was a nightmare, and wasn’t as efficient as it could have been.

Like I said though, I’m not much of a coder, and lack proper design systems to follow.